Fix self-reference cycle in bound_delayed_callback; apply to explosion effect; configure gdlint #73

Merged

cammymoop merged 1 commit from feature/node-bound-delay-fixes into master

2026-03-05 10:24:25 -06:00

claude commented

2026-03-05 10:23:09 -06:00

Collaborator

Summary

Remove — the tween held a reference to itself via its own signal connection, preventing GC after finishing; the call was also a no-op since the tween is already done when fires
Replace with for local type inference consistency
Replace in with — the only other scene tree timer in the codebase — so the lifetime callback is cancelled if the node is freed early
Add with

Test plan

Headless run exits clean with no errors
passes on changed files

## Summary - Remove — the tween held a reference to itself via its own signal connection, preventing GC after finishing; the call was also a no-op since the tween is already done when fires - Replace with for local type inference consistency - Replace in with — the only other scene tree timer in the codebase — so the lifetime callback is cancelled if the node is freed early - Add with ## Test plan - [x] Headless run exits clean with no errors - [x] passes on changed files

claude added 1 commit

2026-03-05 10:23:10 -06:00

Fix self-reference cycle in bound_delayed_callback; apply pattern to explosion effect; configure gdlint line length b69b78ff20

- Remove `delay_tween.finished.connect(delay_tween.kill)` — the tween
  references itself via its own signal connection, preventing GC after
  the tween finishes. The call was also a no-op since the tween is
  already done when `finished` fires.
- Replace `var` with `:=` for local type inference consistency.
- Split overlong doc comment to satisfy gdlint (then added .gdlintrc
  with max-line-length: 280 so future long comments don't need wrapping).
- Replace `get_tree().create_timer()` in explosion_effect.gd with
  `Util.bound_delayed_callback` — the only other scene tree timer in
  the codebase — so the lifetime callback is cancelled if the node is
  freed early.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>